Skip to content

Remove unused Microsoft.Bcl.Memory references - #2567

Merged
aaronpowell merged 1 commit into
CommunityToolkit:mainfrom
aaronpowell:aaronpowell-bcl-memory-override-review
Nov 18, 2026
Merged

aaronpowell merged 1 commit into
CommunityToolkit:mainfrom
aaronpowell:aaronpowell-bcl-memory-override-review

Conversation

@aaronpowell

Copy link
Copy Markdown
Member

N/A (no associated issue)

Remove the stale Microsoft.Bcl.Memory central version and explicit references from both Meilisearch packages. The current MeiliSearch package no longer depends on it.

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • New integration
    • Docs are written
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

Other information

Relates to #2459.

Validation:

  • dotnet build src\CommunityToolkit.Aspire.Meilisearch\CommunityToolkit.Aspire.Meilisearch.csproj - passed (0 warnings, 0 errors).
  • dotnet build src\CommunityToolkit.Aspire.Hosting.Meilisearch\CommunityToolkit.Aspire.Hosting.Meilisearch.csproj - passed (0 warnings, 0 errors).
  • Client non-Docker tests - passed (9/9).
  • Hosting non-Docker tests - passed (10/10).
  • Full test suites were blocked by unavailable Docker and an Aspire CLI connection failure in the TypeScript AppHost test.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 18, 2026 22:50
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.sh | bash -s -- 2567

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.ps1) } 2567"

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the removal of the unused Meilisearch dependency declarations and central version override.

No open issues 🎉

What changed in this PR

Removes unused Microsoft.Bcl.Memory dependency declarations from the Meilisearch integrations and central package management, avoiding the unnecessary version update discussed in #2459.

Changes:

  • Removes explicit package references from both Meilisearch packages.
  • Removes the stale central version override.
File Description
src/​CommunityToolkit.Aspire.Meilisearch/​CommunityToolkit.Aspire.Meilisearch.csproj Removes the client integration’s explicit dependency.
src/​CommunityToolkit.Aspire.Hosting.Meilisearch/​CommunityToolkit.Aspire.Hosting.Meilisearch.csproj Removes the hosting integration’s explicit dependency.
Directory.Packages.props Removes the unused central version override.

Review effort: Balanced

@aaronpowell
aaronpowell merged commit e3fc10c into CommunityToolkit:main Nov 18, 2026
343 of 344 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants